The committers are authorized under a signed CLA.

• ✅ Francisco Marques (65931cd)

Hello @IvanGoncharov , thank you for bringing these up and your detailed comment.
I have made the requested changes:

• Checked the tests folder for the places where this number (or +-1) is used and replace them with this constant.*

$ grep -R "214748364" src  # Intentionally missing the last character
src/type/scalars.ts:export const GRAPHQL_MAX_INT = 2147483647;
src/type/scalars.ts:export const GRAPHQL_MIN_INT = -2147483648;
$ grep -R "2^31" src
src/type/scalars.ts:    'The `Int` scalar type represents non-fractional signed whole numeric values. Int can represent values between -(2^31) and 2^31 - 1.',
$ grep -R "2 \*\* 31" src
# no results

• Converted above comment to JSDoc: separated and simplified them.
• Exported it in src/type/index.ts and src/index.ts.
• Renamed constants to GRAPHQL_INT_MAX and GRAPHQL_INT_MIN.

*Were you also suggesting that tests to these boundaries should be changed?
Ex:

expect(() => parseLiteral('-9876504321')).to.throw(
  'Int cannot represent non 32-bit signed integer value: -9876504321',
);

Would now be

expect(() => parseLiteral(GRAPHQL_MIN_INT-1)).to.throw(
  `Int cannot represent non 32-bit signed integer value: ${GRAPHQL_MIN_INT-1}`,
);

Should I make this change? Thank you.

@IvanGoncharov @saihaj thank you.
Just pushed the requested changes, ready to merge.

@IvanGoncharov I don't think we will be able to merge until you re-review.
Thanks in advance.

@tofran Thanks 👍
Merged 🎉

Just to avoid noise from potential bot accounts.